User Tools

Site Tools


zg:zeitgeist

Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revisionPrevious revision
Next revision
Previous revision
zg:zeitgeist [2010/11/20 16:12] – Update for D7 fgmzg:zeitgeist [2020/11/23 17:23] (current) – external edit 127.0.0.1
Line 6: Line 6:
   * Zeitgeist is essentially fashion for ideas. See a discussion about it on [[http://en.wikipedia.org/wiki/Zeitgeist|Wikipedia]].    * Zeitgeist is essentially fashion for ideas. See a discussion about it on [[http://en.wikipedia.org/wiki/Zeitgeist|Wikipedia]]. 
   * Why the name ? Because when this idea was first discussed, someone on Drupal (chx, I think) said 'Oooh, a Zeitgeist', and I liked it.   * Why the name ? Because when this idea was first discussed, someone on Drupal (chx, I think) said 'Oooh, a Zeitgeist', and I liked it.
-  * [[zg:d6|Preparing for D6]] 
  
 ===== Features ===== ===== Features =====
Line 12: Line 11:
  
   * Log searches with their timestamp   * Log searches with their timestamp
-  * A themable drupal block with the 'n' most recent searches. Since v1.4, 'n' is settable +  * A themable drupal block with the 'n' most recent searches. Since 4.7.x-1.4, 'n' is settable 
-  * A themable drupal block with the 'm' most popular node searches during the current month. Since v1.5, 'm' is settable+  * A themable drupal block with the 'm' most popular node searches during the current month. Since 4.7.x-1.5, 'm' is settable
   * A page displaying the most requested searches over a given time span   * A page displaying the most requested searches over a given time span
-  * 4.7 to 7.0.BETA3 compatible.+  * 4.7.4 to 7.compatible.
  
 ==== Wishlist ==== ==== Wishlist ====
Line 43: Line 42:
 ===== Recurring issue ===== ===== Recurring issue =====
  
-As of 4.7.x/5.x, Drupal does not implement a standard logging API, be it for search or anything else. The net result is that code like zeitgeist.module, which needs to record data from core, must obtain them from undocumented behaviours. +As of 4.7.x/7.x, Drupal does not implement a standard search logging API. The net result is that code like zeitgeist.module, which needs to record data from core, must obtain them from undocumented behaviours. 
  
-  * The core patch from which this module has been born used to parse the standard "watchdog" table.  +  * The core patch from which this module has been born used to parse the standard "watchdog" table from the dblog module.  
-  * For zeitgeist.module 1.1 to 1.6, this meant parsing both the "search form" form and search URL, which led to various problems, notably regarding potential safety issues, and the algorithm proved unreliable over minor core releases changing search.module. +  * For zeitgeist.module 4.7.x-1.1 to 4.7.x-1.6, this meant parsing both the "search form" form and search URL, which led to various problems, notably regarding potential safety issues, and the algorithm proved unreliable over minor core releases changing search.module. 
-  * Version 1.7 only processes the "search form" form. This simplifies the code, but leave it vulnerable to search.module changes.+  * Later versions only alter search forms to add a submit handler. This simplifies the code, but leave it vulnerable to search.module changes.
  
 At some point, drupal core will probably evolve to include such a logging mechanism, and zeitgeist will then be able to use it. Should the module become popular, it is also conceivable that search.module add a recording hook, independent of other recording needs. Things have evolved for the better in Drupal 7, where a single form implementation is used for all search forms, allowing simpler and more generic logging from the form submit handler. At some point, drupal core will probably evolve to include such a logging mechanism, and zeitgeist will then be able to use it. Should the module become popular, it is also conceivable that search.module add a recording hook, independent of other recording needs. Things have evolved for the better in Drupal 7, where a single form implementation is used for all search forms, allowing simpler and more generic logging from the form submit handler.
zg/zeitgeist.1290269523.txt.gz · Last modified: 2020/11/23 17:23 (external edit)