User Tools

Site Tools


zg:zeitgeist

Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revisionPrevious revision
Next revision
Previous revision
zg:zeitgeist [2006/04/08 21:03] fgmzg:zeitgeist [2020/11/23 17:23] (current) – external edit 127.0.0.1
Line 8: Line 8:
  
 ===== Features ===== ===== Features =====
- 
- 
 ==== Current ==== ==== Current ====
  
   * Log searches with their timestamp   * Log searches with their timestamp
-  * A customizable drupal block with the 'n' most recent searches. Since v1.4, 'n' is settable +  * A themable drupal block with the 'n' most recent searches. Since 4.7.x-1.4, 'n' is settable 
-  * A customizable drupal block with the 'm' most popular node searches during the current month. Since v1.5, 'm' is settable +  * A themable drupal block with the 'm' most popular node searches during the current month. Since 4.7.x-1.5, 'm' is settable 
-  * 4.7beta6-compatible +  * A page displaying the most requested searches over a given time span 
- +  * 4.7.4 to 7.x compatible.
  
 ==== Wishlist ==== ==== Wishlist ====
  
-  * A page displaying the most requested searches over a given time span 
   * A RSS feed tracking all searches   * A RSS feed tracking all searches
   * A periodic (weekly) summary of the top queries, by email to the site admin   * A periodic (weekly) summary of the top queries, by email to the site admin
   * A setting to include queries by UID=1 or not   * A setting to include queries by UID=1 or not
 +  * Export the current table -> see offload.module
 +  * Empty the current table
  
 Looking further: Looking further:
  
-  * ability to log various site uses, instead of just searches. +  * ability to log various site uses, instead of just searches -> won't do, use other D6 logging modules. D6 was extended for that reason.
   * coupling with statistics.module   * coupling with statistics.module
 +  * a cleaner way of trapping queries (why not just hook_search ?)
  
 ===== Data ===== ===== Data =====
- +
   * Table 'zeitgeist' contains the search log   * Table 'zeitgeist' contains the search log
   * Variables:   * Variables:
Line 43: Line 42:
 ===== Recurring issue ===== ===== Recurring issue =====
  
-As of 4.7, Drupal does not implement a standard logging API, be it for search or anything else. The net result is that code like zeitgeist.module, which needs to record data from core, must obtain them from undocumented behaviours. +As of 4.7.x/7.x, Drupal does not implement a standard search logging API. The net result is that code like zeitgeist.module, which needs to record data from core, must obtain them from undocumented behaviours.  
 + 
 +  * The core patch from which this module has been born used to parse the standard "watchdog" table from the dblog module.  
 +  * For zeitgeist.module 4.7.x-1.1 to 4.7.x-1.6, this meant parsing both the "search form" form and search URL, which led to various problems, notably regarding potential safety issues, and the algorithm proved unreliable over minor core releases changing search.module. 
 +  * Later versions only alter search forms to add a submit handler. This simplifies the code, but leave it vulnerable to search.module changes. 
 + 
 +At some point, drupal core will probably evolve to include such a logging mechanism, and zeitgeist will then be able to use it. Should the module become popular, it is also conceivable that search.module add a recording hook, independent of other recording needs. Things have evolved for the better in Drupal 7, where a single form implementation is used for all search forms, allowing simpler and more generic logging from the form submit handler. 
 + 
 +Until this happens, it could be possible to use [[http://fr.php.net/manual/en/function.runkit-function-rename.php|runki_function_rename]] to: 
 + 
 +  - rename drupal's do_search function to something like zeitgeist_do_search,  
 +  - implement a local do_search() function in zeitgeist.module. At this point calls by other modules should go to the new function instead of the standard version 
 +  - within this local do_search,  
 +    - perform the _zeitgeist_store_search 
 +    - invoke the standard do_search, now called zeitgeist_do_search 
 +    - return the results obtained from the standard do_search from our custom do_search 
 + 
 +Problems:
  
-  * The core patch from which this module has been born used to parse the standard "watchdog" table.  +  * This would fail if the standard do_search did some stack checking, but the current version doesn't
-  * For zeitgeist.module 1.1 to 1.6, this meant parsing both the "search formform and search URLwhich led to various problems, notably regarding potential safety issues, and the algorithm proved unreliable over minor core releases changing search.module. +  * This requires the experimental "runkitPECL packageabsent from most PHP installations, and apparently unstable
-  * Version 1.7 only processes the "search form" form. This simplifies the code, but leave it vulnerable to search.module changes.+
  
-At some point, drupal core will probably evolve to include such a logging mechanism, and zeitgeist will then be able to use it. Should the module become popular, it is also conceivable that search.module add a recording hook, independent of other recording needs. 
zg/zeitgeist.1144530226.txt.gz · Last modified: 2020/11/23 17:23 (external edit)